Skip to content

Add Firefox support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KarimPwnz wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add Firefox support #2

KarimPwnz wants to merge 11 commits into from

Conversation

@KarimPwnz
Copy link

@KarimPwnz KarimPwnz commented May 2, 2020 •
edited
Loading

I've added Firefox support with the following changes:

  • Added a /s flag equivalent in the wrapper detection of content_script.js (reason: https://bugzilla.mozilla.org/show_bug.cgi?id=1361856)
  • Changed the way popup.js gets data from background.js; it now uses runtime.getBackgroundPage, which is less buggy in Firefox and more conventional in general
  • Renamed chrome/ to src/
  • Added a signature to manifest.json—this causes a "warning" in Chrome, but it is insignificant
  • Defined the HTML encoding of the HTML documents (this removes an annoying warning)
  • Added a signed XPI (postmessage_tracker-1.0.1-fx.xpi) from https://addons.mozilla.org/
  • Updated the version to 1.0.1

This porting works because Firefox supports the chrome namespace.

@KarimPwnz
Copy link
Author

KarimPwnz commented May 2, 2020 •
edited
Loading

If you'd like to maintain the XPI yourself, go to https://addons.mozilla.org/, upload the extension, and change the information in manifest.json.

@KarimPwnz
Copy link
Author

KarimPwnz commented May 2, 2020

Do note that the signing is necessary to install the extension. There is no "developer mode" in standard Firefox.

@vzamanillo
Copy link

vzamanillo commented May 11, 2020

I can confirm that this works on FF 76.0 (64-bit) Linux, good job, waiting for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KarimPwnz @vzamanillo